-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute binaries via npm module #1269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailan
added
enhancement
New feature or request
DO NOT MERGE YET
github_actions
Pull requests that update GitHub Actions code
labels
Aug 5, 2024
JakeChampion
approved these changes
Aug 5, 2024
kpfleming
reviewed
Aug 5, 2024
… package names for import
harmony7
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I have a minor suggestion.
Chatted with @kailan earlier and made sure I understood how this all works, but asked that some additional documentation be written that explains how it works for those unfamiliar with all the NPM magic (e.g. people like myself 🙂). |
Integralist
reviewed
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a step to the release workflow that generates npm modules for each supported platform, as well as a parent module (
@fastly/cli
) that pulls in the correct version for the user usingoptionalDependencies
.This is to enable @harmony7's work in creating a
npm init @fastly/compute
command that can generate Compute projects using the CLI. It will now be possible to run commands without installing the CLI, e.g.npx @fastly/cli compute init
as well as depend on the CLI frompackage.json
in npm projects.It also allows developers without the Fastly CLI to run commands such as
npm run dev
in JavaScript Compute projects (if defined), starting Viceroy.Tagging @JakeChampion as he wrote the code in the wizer repo that I based this upon: https://github.com/bytecodealliance/wizer/tree/main/npm/wizer